Move template compiler creation to a method on the addon #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overridden by plugins (e.g. CSS Blocks) that need access to the input and output trees.
stefanpenner
requested changes
Apr 27, 2020
|
I've upgraded to broccoli-persistent-filter 3.0 which allows us to pick up the proper typescript definitions for that plugin now and use it here. |
|
Landed the broccoli-persistent-filter bump in #557. |
rwjblue
reviewed
May 18, 2020
…don." This reverts commit 7a6d882.
rwjblue
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so it can be overridden by plugins (e.g. CSS Blocks) that need access to the input and output trees.
Relevant to this patch:
Also, I added some typescript types for the template compiler. I can split that off into a separate PR if you want.
Tests? I can add one but I'm not sure exactly what you'd like for me to test. It seems like maybe just a code comment is sufficient.