Enable colocated component classes to be TypeScript #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, we only looked for `*.js` files as the "backing class" and would actually create a `.js` file right next to the existing `.ts` file. This leads to a whole host of bugs for TypeScript users. :( This updates the logic to look for `.js` file first then fall back to `.ts` files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, we only looked for
*.jsfiles as the "backing class" and would actually create a.jsfile right next to the existing.tsfile. This leads to a whole host of bugs for TypeScript users. :(This updates the logic to look for
.jsfile first then fall back to.tsfiles.Address part of #308