Merge pull request #739 from ember-cli/mixonic/allow-console

ember-cli · Dec 5, 2021 · 13284d4 · 13284d4
2 parents 49d9e0f + bd67f24
commit 13284d4
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -78,6 +78,7 @@ jobs:
          - ember-lts-3.8
          - ember-lts-3.20
          - ember-lts-3.24
+         - ember-lts-3.28
          - ember-release
          - ember-beta
          - ember-canary

diff --git a/config/ember-try.js b/config/ember-try.js
@@ -31,12 +31,23 @@ module.exports = async function () {
           },
         },
       },
+      {
+        name: 'ember-lts-3.28',
+        npm: {
+          devDependencies: {
+            'ember-source': '~3.28.0',
+          },
+        },
+      },
       {
         name: 'ember-release',
         npm: {
           devDependencies: {
             'ember-source': await getChannelURL('release'),
           },
+          ember: {
+            edition: 'octane',
+          },
         },
       },
       {
@@ -45,6 +56,9 @@ module.exports = async function () {
           devDependencies: {
             'ember-source': await getChannelURL('beta'),
           },
+          ember: {
+            edition: 'octane',
+          },
         },
       },
       {
@@ -53,6 +67,9 @@ module.exports = async function () {
           devDependencies: {
             'ember-source': await getChannelURL('canary'),
           },
+          ember: {
+            edition: 'octane',
+          },
         },
       },
       {

diff --git a/lib/utils.js b/lib/utils.js
@@ -159,6 +159,7 @@ function getTemplateCompiler(templateCompilerPath, EmberENV = {}) {
 
   let sandbox = {
     EmberENV: clonedEmberENV,
+    console,
 
     // Older versions of ember-template-compiler (up until [email protected])
     // eagerly access `setTimeout` without checking via `typeof` first