Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel as the default parser #107

Conversation

alexlafroscia
Copy link
Collaborator

Note: This is definitely a breaking change that will require a major
version bump and a note in the CHANGELOG about the fact that the
coding-standard files no longer exist (in case someone is upgrading
and currently extending from them).

Closes #81

@BrianSipple BrianSipple mentioned this pull request Aug 19, 2016
@BrianSipple
Copy link
Collaborator

BrianSipple commented Aug 19, 2016

coding-standard/ was a neat experiment, but I think this is the right approach 👍 .

Also, the major version bump just gave me another idea.

@Turbo87
Copy link
Member

Turbo87 commented Aug 19, 2016

@alexlafroscia @BrianSipple can we split this PR in two? I'd like to update the blueprints and README in the first PR, which is a non-breaking change that just deprecates using the coding-standard files. And then in the second PR we can remove those files which then requires the major version bump and can be combined with the switch to ESLint 3.

@alexlafroscia
Copy link
Collaborator Author

Sure, fine by me! I'll update the PR

@Turbo87
Copy link
Member

Turbo87 commented Aug 23, 2016

@alexlafroscia awesome, thanks!

@Turbo87 Turbo87 merged commit 519180e into ember-cli:master Aug 23, 2016
@Turbo87 Turbo87 added this to the 1.8.0 milestone Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants