Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ember 5 #410

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Support for ember 5 #410

merged 2 commits into from
Jun 15, 2023

Conversation

jacobnlsn
Copy link
Contributor

Full disclosure, looked very little into this. I am new to ember and just having issues going through the quick start guide, so spent some time trying to figure out why.

With ember-cli 5 getting released as latest the quick start guide is failing on ember new ember-quickstart --lang en

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/ember-source
npm ERR!   dev ember-source@"~5.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer ember-source@"^3.28.0 || ^4.0.0" from [email protected]
npm ERR! node_modules/ember-cli-app-version
npm ERR!   dev ember-cli-app-version@"^6.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Copy link

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

CI (when someone with the right permissions will enable it here) will still fail probably, as this repo is not setup for Ember 5 yet. We need to add @ember/string as a devDependency I think, or just run ember-cli-update here...

package.json Outdated Show resolved Hide resolved
@kategengler
Copy link
Member

Thank you! Merging with failing scenarios that will be fixed by #411

@kategengler kategengler merged commit 446d490 into ember-cli:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants