Skip to content

Tests should use different output directory as to not troll the library author#57

Merged
NullVoxPopuli merged 2 commits intomainfrom
nvp/tests-use-different-output-direcotry
Jun 10, 2025
Merged

Tests should use different output directory as to not troll the library author#57
NullVoxPopuli merged 2 commits intomainfrom
nvp/tests-use-different-output-direcotry

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 7, 2025

dist is currently very overloaded.

This could lead to things like:

  • accidentally publishing the test-app to npm instead of the rollup's dist output (depends on which order you run things)
  • accidentally thinking self-imports work without a resolve.alias config (which we do have now, but slightly beside the point)

We want it to be possible to:

  • pnpm build
  • pnpm test:ember
  • pnpm publish

and have the correct dist directory be published.

This may beg the question:

  • do we use dist-types instead of declarations? idk 🤷 disco for outside this PR

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review June 7, 2025 23:47
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jun 10, 2025
@NullVoxPopuli NullVoxPopuli merged commit e6f2e8b into main Jun 10, 2025
15 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/tests-use-different-output-direcotry branch June 10, 2025 15:10
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants