Tests should use different output directory as to not troll the library author#57
Merged
NullVoxPopuli merged 2 commits intomainfrom Jun 10, 2025
Merged
Conversation
simonihmig
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distis currently very overloaded.This could lead to things like:
resolve.aliasconfig (which we do have now, but slightly beside the point)We want it to be possible to:
and have the correct
distdirectory be published.This may beg the question:
dist-typesinstead of declarations? idk 🤷 disco for outside this PR