Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to "uglify-js" v3.0.24 #49

Merged
merged 5 commits into from
Jul 9, 2017
Merged

Update to "uglify-js" v3.0.24 #49

merged 5 commits into from
Jul 9, 2017

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jul 9, 2017

This is a breaking change as the options will have to look quite different now.

@Turbo87 Turbo87 requested a review from rwjblue July 9, 2017 14:55
rwjblue
rwjblue approved these changes Jul 9, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

Likely needs a beta period so that we can iron out the other packages involved (e.g. ember-cli-uglify).

@Turbo87 Turbo87 merged commit 5058a81 into ember-cli:master Jul 9, 2017
@Turbo87 Turbo87 deleted the uglify-js-3 branch July 9, 2017 15:08
@Turbo87 Turbo87 mentioned this pull request Jul 9, 2017
Merged
@axiomabsolute axiomabsolute mentioned this pull request Nov 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
breaking enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @rwjblue