Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #54: manifest.txt should be uploaded as last #55

Merged
merged 3 commits into from
May 12, 2016
Merged

Fix issue #54: manifest.txt should be uploaded as last #55

merged 3 commits into from
May 12, 2016

Conversation

YoranBrondsema
Copy link
Contributor

Fixes #54.

@ghedamat
Copy link
Contributor

hi @YoranBrondsema thanks for this!

it LGTM but I'd like @achambers or @lukemelia to give it a second look as well (it's late here ;P)

@ghedamat ghedamat self-assigned this May 10, 2016
@ghedamat ghedamat added the bug label May 10, 2016
@lukemelia
Copy link
Contributor

Thanks for this @YoranBrondsema. Looks great. Would you mind squashing this to a single commit and we can get it merged?

@ghedamat ghedamat merged commit bfa3c68 into ember-cli-deploy:master May 12, 2016
@ghedamat
Copy link
Contributor

@lukemelia used the nice squash-merge gh feature :D seems to work :P

@wongpeiyi wongpeiyi mentioned this pull request Aug 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ghedamat ghedamat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YoranBrondsema @ghedamat @lukemelia