Add support for ACL on objects

[flecno]

No description provided.

[achambers]

@flecno I can't see where you are setting the default value in the code. Can you please follow the conventions of the other default values in this file?

[flecno]

You are right. It's not really explicit. The default already exists in

ember-cli-deploy-s3/lib/s3.js

Line 68 in 59e083a

var acl = options.acl || 'public-read';

But I would prefer to move the default to another place too. I will look into the other defaults.

[achambers]

Cool. If you're going to make it a part of the plugin config then the
default should be moved out of there and into the index.js. Let me know
when you've updated it and I'll take a look.

Thanks for your contributions.
On Sun, 25 Oct 2015 at 20:46 Timo Zingel [email protected] wrote:

In README.md
#20 (comment)
:

@@ -85,6 +85,12 @@ The region the AWS bucket is located in.

Default: us-east-1

+### acl
+
+The ACL to apply to the objects.
+
+Default: public-read

You are right. It's not really explicit. The default already exists in

ember-cli-deploy-s3/lib/s3.js

Line 68 in 59e083a

var acl = options.acl || 'public-read';

But I would prefer to move the default to another place too. I will look
into the other defaults.

—
Reply to this email directly or view it on GitHub
https://github.com/ember-cli-deploy/ember-cli-deploy-s3/pull/20/files#r42950148
.

[flecno]

@achambers here is an update. What do you say? :)

[flecno]

I rebased this to latest master. Can you review this please?

[ghedamat]

@flecno LGTM, thanks!