contentType handled properly #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukemelia can you check this PR |
|
Would be great to get this merged, just ran into this problem and this fixed it up nicely. Previously the content type was only set properly for top-level assets. |
|
Thanks for the reminder @BenV , and thanks for the implementation @prem-chandar. I previously had not acted on this since it had no tests or reproduction steps. After evaluating it with other members of the ember-cli-deploy team, we decided to merge it. |
|
Awesome, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
when the assets are present inside sub-folder content type for the .gz, .br extension files are not set properly.
Related issues
Link to related issues in this or other repositories (if any)
PR Checklist
People
Mention people who would be interested in the changeset (if any)