Skip to content

Upgrade ember-cli, ember-cli-babel, ember-cli-htmlbars and ember-cli-shims #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astronomersiva wants to merge 1 commit into from
Closed

Upgrade ember-cli, ember-cli-babel, ember-cli-htmlbars and ember-cli-shims #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"test": "tests"
},
"scripts": {
"test": "node tests/runner.js && ./node_modules/.bin/eslint index.js tests/**/*.js"
"test": "node tests/runner.js && eslint index.js tests/**/*.js"
},
"repository": "https://github.com/ember-cli-deploy/ember-cli-deploy-build",
"engines": {
Expand All @@ -22,13 +22,13 @@
"rsvp": "^3.5.0"
},
"devDependencies": {
"chai-as-promised": "^6.0.0",
"chai": "^3.5.0",
"ember-cli-babel": "^5.2.4",
"ember-cli-htmlbars": "^1.2.0",
"chai-as-promised": "^6.0.0",
"ember-cli": "^3.1.4",
"ember-cli-babel": "^6.14.1",
"ember-cli-htmlbars": "^2.0.3",
"ember-cli-release": "^1.0.0-beta.2",
"ember-cli-shims": "^1.0.2",
"ember-cli": "^2.12.0",
"ember-cli-shims": "^1.2.0",
"ember-source": "^2.12.0",
"eslint": "^3.18.0",
"github": "^0.2.4",
Expand Down
11 changes: 8 additions & 3 deletions tests/index-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ var chaiAsPromised = require("chai-as-promised");
chai.use(chaiAsPromised);
var assert = chai.assert;
var Project = require('ember-cli/lib/models/project');
var baseSubject = require('../index');
Copy link
Author

@astronomersiva astronomersiva Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer emberjs/ember-cli-babel#171 (comment)


describe('build plugin', function() {
var subject, mockUi, config;

beforeEach(function() {
subject = require('../index');
subject = baseSubject;
mockUi = {
messages: [],
verbose: true,
Expand Down Expand Up @@ -135,6 +136,8 @@ describe('build plugin', function() {
}
}
};

plugin.beforeHook(context);
});

afterEach(function() {
Expand All @@ -144,7 +147,10 @@ describe('build plugin', function() {

it('builds the app and resolves with distDir and distFiles', function(done) {
this.timeout(50000);
plugin.beforeHook(context);

var willInterruptProcess = require('ember-cli/lib/utilities/will-interrupt-process');
willInterruptProcess.capture(process);

assert.isFulfilled(plugin.build(context))
.then(function(result) {
assert.deepEqual(result, {
Expand Down Expand Up @@ -176,7 +182,6 @@ describe('build plugin', function() {
it('can reuse build results and resolve with distDir and distFiles', function(done) {
process.env.EMBER_CLI_DEPLOY_REUSE_BUILD = 'true';
context.config.build.outputPath = __dirname + '/fixtures/fake-build-output';
plugin.beforeHook(context);

assert.isFulfilled(plugin.build(context))
.then(function(result) {
Expand Down
Loading