Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chrome for CI tests #32

Closed
wants to merge 1 commit into from

Conversation

BrianSipple
Copy link
Member

From what I've been able to gather, the test failures in #28 all seem to be due to PhantomJS not supporting either Array.find or HTMLElement.remove().

All tests pass in Chrome.

With that in mind, now might be a great opportunity to set up Chrome for CI tests -- especially given how much we're doing with the DOM. All we need is a few travis.yml and testem tweaks, and we'd be all set.

@nathanhammond
Copy link
Contributor

I'm actually opposed to this since every Ember app is set up to use Phantom by default. It'd be really easy for us to accidentally introduce a feature that didn't work on Phantom once we move CI to Chrome. I'd much rather ship a polyfill for this behavior in our tests so that we don't accidentally introduce regressions–especially since our code is designed to be run at test time.

@BrianSipple
Copy link
Member Author

@nathanhammond Good point, I hadn't yet wrapped my brain around the fact that we're designing for use in tests here as well. I'll close the issue -- I think those concerns far outweigh the benefits atm -- but hey, it's good to know now that this challenge might come up!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants