Add more descriptive violation logging

[aliciasedlock]

Original PR from ember-axe: trentmwillis/ember-axe#7

As we are about to use this add-on in a new application, the other developer and I thought it would be nice to have more descriptive logging in the console rather than sifting through the violations object output.

This both updates the default messages that is displayed inside the browser test runner, along with more precise console logging, rather than dumping the entire violations object flat out.

New test runner messaging

#### New console level information

[nathanhammond]

What if this string is absurdly long?

[aliciasedlock]

Good point. There is potential for it to contain a lot of nodes, so perhaps the intent of having the node list at this level makes it less useful.

I can potentially log how many specific violations of that type are present and instead provide an object or array of the offending elements.

On Jun 2, 2016, 12:30 AM -0400, Nathan [email protected], wrote:

Incontent-for/test-body-footer.html(#25 (comment)):

},>>/**>+ * Takes the violations' nodes param and converts it to>+ * a string that can be displayed with the console error.>+ * @param {Array} nodes>+ * @return {String}>+ */>+ nodesToString: function(nodes) {>+ return nodes.map(function(node) {>+ return node.html;>+ }).join(', ');

What if this string is absurdly long?

—
You are receiving this because you authored the thread.
Reply to this email directly,view it on GitHub(https://github.com/ember-a11y/ember-a11y-testing/pull/25/files/f15c6f6bb86efa59014b009c10f876c3a0d8d07a#r65482880), ormute the thread(https://github.com/notifications/unsubscribe/AAjYQcgi1ArUeP2C8jfGzrYQVyhy-LiBks5qHlxrgaJpZM4IsIU9).

[aliciasedlock]

Change has been implemented locally, but I would like to test this on our application prior to marking this as ready.

[nathanhammond]

Remove the WIP flag and drop another note here when you're calling it ready and I'll merge. 😄 Thanks for your efforts on this!

[aliciasedlock]

@nathanhammond Second pass done! Screenshot is updated, we now list the number of violations and a separate violations array with the specific nodes in it, rather than converting them to a string.

[nathanhammond]

Thank you @aliciasedlock!