chore(deps): update eslint (major) #230

renovate · 2020-12-01T22:43:03Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
eslint-config-prettier	`^6.11.0` -> `^8.0.0`
eslint-plugin-ember	`^9.0.0` -> `^10.0.0`

Release Notes

prettier/eslint-config-prettier

`v8.2.0`

Compare Source

Added: [flowtype/quotes]. Thanks to Martin Zlámal (@mrtnzlml)!

`v8.1.0`

Compare Source

Added: [flowtype/object-type-curly-spacing].
Added: Dummy files for the configs removed in 8.0.0. The dummy files throw an error that try to guide you how to upgrade.

`v8.0.0`

Compare Source

Changed: All configs have been merged into one!

To upgrade, change:
```
{
  "extends": [
    "some-other-config-you-use",
    "prettier",
    "prettier/@&#8203;typescript-eslint",
    "prettier/babel",
    "prettier/flowtype",
    "prettier/react",
    "prettier/standard",
    "prettier/unicorn",
    "prettier/vue"
  ]
}
```
Into:
```
{
  "extends": [
    "some-other-config-you-use",
    "prettier"
  ]
}
```
The "prettier" config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!

So … what’s the catch? Why haven’t we done this earlier? Turns out it’s just a sad mistake. I (@lydell) was confused when testing, and thought that turning off unknown rules in a config was an error. Thanks to Georgii Dolzhykov (@thorn0) for pointing this out!

If you use [eslint-plugin-prettier], all you need is [plugin:prettier/recommended]:
```
{
  "extends": [
    "some-other-config-you-use",
    "plugin:prettier/recommended"
  ]
}
```
(The ["prettier/prettier" config][prettier-prettier-config] still exists separately. It’s the odd one out. The main "prettier" config does not include the rules from it.)
Changed: The CLI helper tool now only prints warnings for [arrow-body-style] and [prefer-arrow-callback], just like other “special rules.” This means that if you’ve decided to use those rules and [eslint-plugin-prettier] at the same time, you’ll get warnings but exit code zero (success).

`v7.2.0`

Compare Source

Added: [@typescript-eslint/object-curly-spacing].
Added: [react/jsx-newline].

`v7.1.0`

Compare Source

Added: [unicorn/empty-brace-spaces]. Thanks to fisker Cheung (@fisker)!

`v7.0.0`

Compare Source

Changed: At least ESLint 7.0.0 is now required.
Changed: [arrow-body-style] and [prefer-arrow-callback] are no longer turned off by default. They only need to be turned off if you use [eslint-plugin-prettier]. If you do, add "prettier/prettier" to your "extends" array to turn them off again.
```
{
  "extends": ["prettier", "prettier/prettier"],
  "plugins": ["prettier"],
  "rules": {
    "prettier/prettier": "error"
  }
}
```
Alternatively, update [eslint-plugin-prettier] to version 3.2.0 or later which automatically turns off these two rules in its "plugin:prettier/recommended" config.

The CLI helper tool only warns about these rules if you have the "prettier/prettier" rule enabled for a file.
Changed: no-tabs is now a validatable rule. If you use it, you should enable allowIndentationTabs so that the rule works regardless of your Prettier config:
```
{
  "rules": {
    "no-tabs": ["error", { "allowIndentationTabs": true }]
  }
}
```
Changed: The CLI helper tool is now called just eslint-config-prettier instead of eslint-config-prettier-check. This is so that npx eslint-config-prettier always works regardless of whether you have already installed eslint-config-prettier or not: If you have, the local installation is used; if you haven’t, npx downloads a temporary copy.
Changed: The CLI helper tool no longer requires you to pipe the output of eslint --print-config to it. Instead, it does that automatically for you via ESLint API:s added in ESLint v7.

Before:
```
npx eslint --print-config index.js | npx eslint-config-prettier-check
```
After:
```
npx eslint-config-prettier index.js
```
Improved: The npm package is now 75% smaller.

`v6.15.0`

Compare Source

Added: [@typescript-eslint/space-infix-ops]. Thanks to Masafumi Koba (@ybiquitous)!

`v6.14.0`

Compare Source

Added: New [eslint-plugin-vue] rules: [vue/array-bracket-newline] and [vue/block-tag-newline]. Thanks to @xcatliu!

`v6.13.0`

Compare Source

Added: New rules in [eslint-plugin-vue] 7.0 (which supports Vue 3.0). Thanks to @xcatliu!

`v6.12.0`

Compare Source

Added: [@typescript-eslint/comma-dangle]. Thanks to Masafumi Koba (@ybiquitous)!

ember-cli/eslint-plugin-ember

`v10.3.0`

Compare Source

🚀 Enhancement

#1113 Add additionalClassImports option to no-classic-classes rule (@scalvert)

🐛 Bug Fix

#1115 Fix crash with dynamic/variable route name in no-shadow-route-definition rule (@bmish)
#1102 Fix crash with this.extend() in no-classic-classes rule (@bmish)
#1114 Ensure rules validate arrays in options to have at least one item and unique items (@bmish)
#1103 Only calculate source module name once in import util function for slight optimization (@bmish)
#1081 Update avoid-leaking-state-in-ember-objects rule to apply to mixins (@jaydgruber)

Committers: 3

Bryan Mishkin (@bmish)
Steve Calvert (@scalvert)
@jaydgruber

`v10.2.0`

Compare Source

🚀 Enhancement

#1079 Add new rule no-html-safe (@patocallaghan)

🐛 Bug Fix

#1072 Improve jquery detection in jquery-ember-run rule (@bmish)

Committers: 2

Bryan Mishkin (@bmish)
Pat O'Callaghan (@patocallaghan)

`v10.1.2`

Compare Source

🐛 Bug Fix

#1063 Improve detection of globals and catch additional jQuery function calls in no-jquery rule (@BarryThePenguin)
#1066 Improve detection of globals in no-global-jquery rule (@bmish)

🏠 Internal

#1069 Improve tests for jquery-ember-run rule (@bmish)

Committers: 2

Bryan Mishkin (@bmish)
Jonathan Haines (@BarryThePenguin)

`v10.1.1`

Compare Source

🐛 Bug Fix

#1059 Do not warn about Glimmer lifecycle hooks on classic components in no-component-lifecycle-hooks rule (@Turbo87)

🏠 Internal

#1060 Automate release process with release-it-lerna-changelog (@bmish)

Committers: 2

Bryan Mishkin (@bmish)
Tobias Bieniek (@Turbo87)

`v10.1.0`

Compare Source

🚀 Enhancement

#1056 Add new rule no-current-route-name (@Turbo87)
#1055 Add new rule require-fetch-import (@Turbo87)

🐛 Bug Fix

#1054 Handle commas inside quotes in selectors in require-valid-css-selector-in-test-helpers rule (@bmish)
#1051 Fix path checks for Windows in no-test-import-export and no-test-support-import rules (@dwickern)
#1038 Improve detection of global window methods in prefer-ember-test-helpers rule (@bmish)
#1043 Fix false positive in no-shadow-route-definition rule (@raido)
#1040 willDestroy should be considered a classic component lifecycle hook in require-super-in-lifecycle-hooks and no-component-lifecycle-hooks rules (@bmish)
#1036 Catch willDestroy Glimmer component hook in require-super-in-lifecycle-hooks rule (@bmish)

🏠 Internal

#1052 Add Windows to CI testing matrix (@dwickern)

Committers: 4

Bryan Mishkin (@bmish)
Derek Wickern (@dwickern)
Raido Kuli (@raido)
Tobias Bieniek (@Turbo87)

`v10.0.2`

Compare Source

🐛 Bug Fix

#1029 Handle comma-separated selectors in require-valid-css-selector-in-test-helpers rule (@bmish)
#1030 Allow using string functions directly from Ember in no-string-prototype-extensions rule (@bmish)

📝 Documentation

#1028 Mention Ember 3.13 minimum version to use tracked properties and Glimmer components in some rule docs (@bmish)

Committers: 1

Bryan Mishkin (@bmish)

`v10.0.1`

Compare Source

🐛 Bug Fix

#1027 Fix crash when non-expression precedes settled() in no-settled-after-test-helper rule (@Turbo87)

Committers: 1

Tobias Bieniek (@Turbo87)

Committers: 3

Bryan Mishkin (@bmish)
Jeff Sturgis (@jsturgis)
Joel Bradshaw (@cincodenada)

`v9.6.0`

Compare Source

🚀 Enhancement

#1000 Add catchSafeObjects and catchUnsafeObjects options (default false) to no-get-with-default rule (@bmish)

🐛 Bug Fix

#1001 Fix issues with no-get rule autofix with array access in nested path (@bmish)

Committers: 1

Bryan Mishkin (@bmish)

`v9.5.0`

Compare Source

🚀 Enhancement

#993 Add new rule no-empty-glimmer-component-classes (@hxqlin)

🐛 Bug Fix

#998 Fix autofix for array element access at beginning of path string in no-get rule (@bmish)

Committers: 2

Bryan Mishkin (@bmish)
Hannah Lin (@hxqlin)

`v9.4.0`

Compare Source

🚀 Enhancement

#985 Add new rule no-settled-after-test-helper (@Turbo87)
#978 Add new rule no-shadow-route-definition (@raido)
#986 Add new rule no-string-prototype-extensions (@Turbo87)
#980 Add new rule require-valid-css-selector-in-test-helpers (@jsturgis)

🏠 Internal

#991 Add test to ensure rule test files have correct test suite name (@bmish)

Committers: 4

Bryan Mishkin (@bmish)
Jeff Sturgis (@jsturgis)
Raido Kuli (@raido)
Tobias Bieniek (@Turbo87)

`v9.3.0`

Compare Source

🚀 Enhancement

#973 Add new rule no-try-invoke (@bachvo)

🐛 Bug Fix

#971 Handle path separators for different platforms in no-test-support-import rule (@bmish)

Committers: 2

Bryan Mishkin (@bmish)
bach vo (@bachvo)

`v9.2.0`

Compare Source

🚀 Enhancement

#966 Add new rule no-test-support-import (@gabrielcsapo)

🐛 Bug Fix

#967 Avoid false positives and properly check imports in no-observers rule (@bmish)

Committers: 2

Bryan Mishkin (@bmish)
Gabriel Csapo (@gabrielcsapo)

`v9.1.1`

Compare Source

🐛 Bug Fix

#962 Do not pass ...arguments in autofix for attrs hooks in require-super-in-init rule (@bmish)

Committers: 1

Bryan Mishkin (@bmish)

`v9.1.0`

Compare Source

🚀 Enhancement

#961 Add checkPlainGetters option (default false) to no-side-effects rule (@bmish)
#957 Add checkInitOnly (default true) and checkNativeClasses (default false) options to require-super-in-init rule (@bmish)
#950 Add autofixer to require-super-in-init rule (@bmish)

📝 Documentation

#956 Add imports in no-test-module-for rule doc (@bmish)

🏠 Internal

#945 Add sort-package-json (@bmish)
#944 Ensure rule doc notices are present in the correct order (@bmish)

Committers: 1

Bryan Mishkin (@bmish)

Configuration

📅 Schedule: "after 10pm every weekday,before 5am every weekday,every weekend" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

drewlee · 2021-02-25T01:43:04Z

This one is going to need some work. It introduces a bunch of linting errors that need to be addressed.

renovate bot force-pushed the renovate/major-eslint branch from efc3555 to 4c0f5bb Compare December 5, 2020 21:59

renovate bot changed the title ~~chore(deps): update dependency eslint-plugin-ember to v10~~ chore(deps): update eslint (major) Dec 5, 2020

renovate bot force-pushed the renovate/major-eslint branch from 4c0f5bb to 246b475 Compare February 7, 2021 22:00

renovate bot changed the title ~~chore(deps): update eslint (major)~~ Update eslint (major) Feb 9, 2021

renovate bot force-pushed the renovate/major-eslint branch from 246b475 to ca381f1 Compare February 21, 2021 11:58

renovate bot changed the title ~~Update eslint (major)~~ chore(deps): update eslint (major) Mar 2, 2021

renovate bot force-pushed the renovate/major-eslint branch from ca381f1 to 02e134f Compare April 6, 2021 07:25

drewlee mentioned this pull request Apr 16, 2021

Removes deprecated visual audit related components #255

Merged

scalvert force-pushed the renovate/major-eslint branch from 02e134f to a0b90d9 Compare April 19, 2021 16:30

renovate-bot and others added 2 commits April 19, 2021 14:03

chore(deps): update eslint

9c314a0

Rebase, allow all try:each scenarios to pass

a3d9498

drewlee force-pushed the renovate/major-eslint branch from a0b90d9 to a3d9498 Compare April 19, 2021 21:37

drewlee merged commit 0f4e5cf into master Apr 19, 2021

renovate bot deleted the renovate/major-eslint branch April 19, 2021 21:44

drewlee added the internal label Apr 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update eslint (major) #230

chore(deps): update eslint (major) #230

renovate bot commented Dec 1, 2020 •

edited

Loading

drewlee commented Feb 25, 2021

chore(deps): update eslint (major) #230

chore(deps): update eslint (major) #230

Conversation

renovate bot commented Dec 1, 2020 • edited Loading

Release Notes

🚀 Enhancement

🐛 Bug Fix

Committers: 3

🚀 Enhancement

🐛 Bug Fix

Committers: 2

🐛 Bug Fix

🏠 Internal

Committers: 2

🐛 Bug Fix

🏠 Internal

Committers: 2

🚀 Enhancement

🐛 Bug Fix

🏠 Internal

Committers: 4

🐛 Bug Fix

📝 Documentation

Committers: 1

🐛 Bug Fix

Committers: 1

💥 Breaking Change

📝 Documentation

Committers: 3

🚀 Enhancement

🐛 Bug Fix

Committers: 1

🚀 Enhancement

🐛 Bug Fix

Committers: 2

🚀 Enhancement

🏠 Internal

Committers: 4

🚀 Enhancement

🐛 Bug Fix

Committers: 2

🚀 Enhancement

🐛 Bug Fix

Committers: 2

🐛 Bug Fix

Committers: 1

🚀 Enhancement

📝 Documentation

🏠 Internal

Committers: 1

Configuration

drewlee commented Feb 25, 2021

renovate bot commented Dec 1, 2020 •

edited

Loading