Skip to content

Commit

Permalink
Merge pull request #26 from BrianSipple/update-to-ember-cli-2.6
Browse files Browse the repository at this point in the history
The issues above have been address -- and because I kept this out for a bit longer than I had planned, I bumped the version from Ember-CLI 2.6.1 to 2.6.2
  • Loading branch information
Brian Sipple authored Jun 21, 2016
2 parents 1adb17a + df4cfbd commit 45d0e55
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 26 deletions.
11 changes: 6 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,15 @@ matrix:
- env: EMBER_TRY_SCENARIO=ember-canary

before_install:
- export PATH=/usr/local/phantomjs-2.0.0/bin:$PATH
- "npm config set spin false"
- "npm install -g npm@^2"
- npm config set spin false
- npm install -g bower
- npm install phantomjs-prebuilt

install:
- npm install -g bower
- npm install
- bower install

script:
- ember try $EMBER_TRY_SCENARIO test
# Usually, it's ok to finish the test scenario without reverting
# to the addon's original dependency state, skipping "cleanup".
- ember try $EMBER_TRY_SCENARIO test --skip-cleanup
4 changes: 2 additions & 2 deletions bower.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "ember-a11y-testing",
"dependencies": {
"ember": "~2.5.0",
"axe-core": "~1.1.1",
"ember": "~2.6.0",
"ember-cli-shims": "0.1.1",
"ember-cli-test-loader": "0.2.2",
"ember-qunit-notifications": "0.1.0",
"axe-core": "~1.1.1",
"sinonjs": "~1.14.1"
}
}
10 changes: 4 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"scripts": {
"build": "ember build",
"start": "ember server",
"test": "ember try:testall"
"test": "ember try:each"
},
"repository": {
"type": "git",
Expand All @@ -22,25 +22,23 @@
"license": "MIT",
"devDependencies": {
"broccoli-asset-rev": "^2.4.2",
"ember-ajax": "0.7.1",
"ember-cli": "2.5.1",
"ember-ajax": "^2.0.1",
"ember-cli": "2.6.2",
"ember-cli-app-version": "^1.0.0",
"ember-cli-dependency-checker": "^1.2.0",
"ember-cli-htmlbars": "^1.0.3",
"ember-cli-htmlbars-inline-precompile": "^0.3.1",
"ember-cli-inject-live-reload": "^1.4.0",
"ember-cli-jshint": "^1.0.0",
"ember-cli-qunit": "^1.4.0",
"ember-cli-release": "0.2.8",
"ember-cli-release": "0.2.9",
"ember-cli-sri": "^2.1.0",
"ember-cli-uglify": "^1.2.0",
"ember-data": "^2.5.0",
"ember-disable-prototype-extensions": "^1.1.0",
"ember-export-application-global": "^1.0.5",
"ember-load-initializers": "^0.5.1",
"ember-resolver": "^2.0.3",
"ember-sinon": "0.5.1",
"ember-try": "0.2.2",
"loader.js": "^4.0.1"
},
"keywords": [
Expand Down
5 changes: 3 additions & 2 deletions tests/.jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"node": false,
"browser": false,
"boss": true,
"curly": false,
"curly": true,
"debug": false,
"devel": false,
"eqeqeq": true,
Expand All @@ -47,5 +47,6 @@
"strict": false,
"white": false,
"eqnull": true,
"esnext": true
"esnext": true,
"unused": true
}
12 changes: 6 additions & 6 deletions tests/helpers/module-for-acceptance.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
import { module } from 'qunit';
import Ember from 'ember';
import startApp from '../helpers/start-app';
import destroyApp from '../helpers/destroy-app';

const { RSVP: { Promise } } = Ember;

export default function(name, options = {}) {
module(name, {
beforeEach() {
this.application = startApp();

if (options.beforeEach) {
options.beforeEach.apply(this, arguments);
return options.beforeEach.apply(this, arguments);
}
},

afterEach() {
if (options.afterEach) {
options.afterEach.apply(this, arguments);
}

destroyApp(this.application);
let afterEach = options.afterEach && options.afterEach.apply(this, arguments);
return Promise.resolve(afterEach).then(() => destroyApp(this.application));
}
});
}
12 changes: 7 additions & 5 deletions tests/unit/instance-initializers/axe-component-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ test('turnAuditOff prevents audit from running on didRender', function(assert) {
/* Ember.Component.audit */

test('audit should log any violations found', function(assert) {
let a11yCheckStub = sandbox.stub(axe, 'a11yCheck', function(el, options, callback) {
sandbox.stub(axe, 'a11yCheck', function(el, options, callback) {
callback({
violations: [{
name: 'test',
Expand All @@ -110,12 +110,12 @@ test('audit should log any violations found', function(assert) {
assert.ok(logSpy.calledOnce);
});

skip('audit should mark the DOM nodes of any violations', function(assert) {
skip('audit should mark the DOM nodes of any violations', function(/* assert */) {

});

test('audit should do nothing if no violations found', function(assert) {
let a11yCheckStub = sandbox.stub(axe, 'a11yCheck', function(el, options, callback) {
sandbox.stub(axe, 'a11yCheck', function(el, options, callback) {
callback({
violations: []
});
Expand All @@ -133,7 +133,8 @@ test('audit should do nothing if no violations found', function(assert) {

test('axeCallback receives the results of the audit', function(assert) {
let results = { violations: [] };
let a11yCheckStub = sandbox.stub(axe, 'a11yCheck', (el, opts, callback) => {

sandbox.stub(axe, 'a11yCheck', (el, opts, callback) => {
callback(results);
});

Expand All @@ -150,7 +151,8 @@ test('axeCallback receives the results of the audit', function(assert) {

test('axeCallback throws an error if it is not a function', function(assert) {
let results = { violations: [] };
let a11yCheckStub = sandbox.stub(axe, 'a11yCheck', (el, opts, callback) => {

sandbox.stub(axe, 'a11yCheck', (el, opts, callback) => {
callback(results);
});

Expand Down

0 comments on commit 45d0e55

Please sign in to comment.