-
Notifications
You must be signed in to change notification settings - Fork 559
feat: Added get_benchmark_result() to BenchmarkResults to obtain a benchmark table
#3771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Samoed
merged 22 commits into
embeddings-benchmark:main
from
ayush1298:update_BenchmarkResults
Dec 23, 2025
+798
−33
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e9ac0b3
Update BenchmarkResults to output results of benchmark
ayush1298 da19022
added score column and correct TYPE_CHECKING
ayush1298 c5f99b4
address comments
ayush1298 d65b11c
address comments
ayush1298 009ab56
fix import
ayush1298 161822e
fix tests
ayush1298 8c09cde
fix tests
ayush1298 fa2522b
change BenchmarkResults to Pydantic dataclass
ayush1298 b36d0f9
change benchmark to pydantic dataclass
ayush1298 f48c6d2
fix tests
ayush1298 b1445c5
fix model
Samoed 068c032
fix
Samoed 85c20d0
lint
Samoed 48068ad
remove future
Samoed fdfd9f2
fix after review
Samoed 584fe87
add test
Samoed fd4dda4
reapply comments from review
Samoed 090b89f
remove mock benchmark
Samoed 55d34ad
add documentation
ayush1298 467664d
added actual results
ayush1298 f258521
Update docs/usage/loading_results.md
Samoed 03cbfee
add actual results
Samoed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samoed marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not at the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems with circular imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm would be great to avoid it - seems like AbsTask could be moved to type checking
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem not with
AbsTaskMoving table imports inside it's functions is easiest solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us keep it as is - I might refactor the imports later, but for now I think this is reasoable