Added revision parameter for results repo#3764
Added revision parameter for results repo#3764Samoed merged 3 commits intoembeddings-benchmark:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a revision parameter to the download_from_remote method in the ResultCache class, allowing users to specify a specific branch, tag, or commit to checkout from the results repository.
Key changes:
- Added
revisionparameter todownload_from_remotemethod signature and documentation - Modified git operations to support checking out specific revisions when cloning or updating the repository
- Updated fetch logic to use
git fetch --all --tagsinstead ofgit pullwhen a revision is specified
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Samoed, I have removed the depth 1 thing and then tested it with below code: but I am getting below error: I think issue was with my git version, because when I have tested command: it works perfectly fine and I have also confirmed it from logs that correct revision is cloned |
Yes, this command is working for me too, even with |
I think removing Anything other in this PR? |
You shoudn't remove it |
Why so? I think as copilot mentioned it will be better to remove it |
With it downloading repo will be much faster. Also, you don't use |
Added it again. |
There was a problem hiding this comment.
This looks good to me - thanks for the change! Unsure if we want to add some tests here though
@Samoed any remaining concerns?
Closes #3179