Skip to content

feat: make STS and PairClassification asymmetric#3568

Merged
Samoed merged 5 commits intomainfrom
prompt_type_pair_classification
Nov 25, 2025
Merged

feat: make STS and PairClassification asymmetric#3568
Samoed merged 5 commits intomainfrom
prompt_type_pair_classification

Conversation

@Samoed
Copy link
Member

@Samoed Samoed commented Nov 15, 2025

Close #3551

Make STS and PairClassification support prompt_type for different columns.

But this is not backward compatible in scores for models with query/document separation. Example for intfloat/multilingual-e5-small

Task main PR
TERRa 0.575105 0.589083

adapted_from: Sequence[str] | None = None
is_public: bool = True
superseded_by: str | None = None
asymmetric_type: AsymmetricTypes | None = None
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we can just change to bool | None and use input1_prompt_type to use choose prompt_type

@Samoed
Copy link
Member Author

Samoed commented Nov 20, 2025

I'm not sure what to do with retrieval. Do we want to add query_input_type/corpus_input_type or model author's can explicitly add prompts (or we can do this based on metadata)?

@KennethEnevoldsen
Copy link
Contributor

KennethEnevoldsen commented Nov 20, 2025

I'm not sure what to do with retrieval. Do we want to add query_input_type/corpus_input_type or model author's can explicitly add prompts (or we can do this based on metadata)?

I am not sure either - should we get an opinion from e.g. Orion? (in an issue)

@Samoed
Copy link
Member Author

Samoed commented Nov 22, 2025

I think we can create make similar for retrieval in other PR

@Samoed Samoed merged commit 5010468 into main Nov 25, 2025
9 of 10 checks passed
@Samoed Samoed deleted the prompt_type_pair_classification branch November 25, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prompt asymmetry in PairClf and STS

2 participants