Skip to content

fix: Roll back setting OMP_NUM_THREADS for clustering #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KennethEnevoldsen merged 2 commits into from
Oct 20, 2025
Merged

fix: Roll back setting OMP_NUM_THREADS for clustering #3444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccf32ed
test: disable flaky test
KennethEnevoldsen Oct 20, 2025
954d98c
fix: Roll back setting OMP_NUM_THREADS for clustering
KennethEnevoldsen Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions mteb/abstasks/clustering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import itertools
import logging
import os
import random
from collections import defaultdict
from pathlib import Path
Expand Down Expand Up @@ -32,7 +31,6 @@


MultilingualDataset = dict[HFSubset, DatasetDict]
OMP_NUM_THREADS = 4


def _evaluate_clustering_bootstrapped(
Expand All @@ -55,17 +53,6 @@ def _evaluate_clustering_bootstrapped(
- A dictionary where keys are level names (e.g., "Level 0", "Level 1", etc.) and values are lists of V-measure scores for each clustering experiment at that level.
- A dictionary where keys are level names and values are lists of cluster assignments for each clustering experiment at that level.
"""
# set OMP_NUM_THREADS for reproductibility
if "OMP_NUM_THREADS" not in os.environ:
logger.info(
f"Setting OMP_NUM_THREADS to {OMP_NUM_THREADS} for clustering to ensure reproducibility."
)
os.environ["OMP_NUM_THREADS"] = str(OMP_NUM_THREADS)
else:
logger.info(
f"Using existing OMP_NUM_THREADS={os.environ['OMP_NUM_THREADS']} for clustering, this may lead to non-reproducible results. Set it to {OMP_NUM_THREADS} to ensure reproducibility."
)

v_measures = defaultdict(list)
cluster_assignments = defaultdict(list)
if max_depth is not None:
Expand Down
11 changes: 6 additions & 5 deletions tests/test_abstasks/test_predictions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
from tests.mock_tasks import (
MockBitextMiningTask,
MockClassificationTask,
MockClusteringFastTask,
MockClusteringTask,
MockImageTextPairClassificationTask,
MockPairClassificationTask,
Expand Down Expand Up @@ -97,10 +96,12 @@
},
),
(MockClusteringTask(), [[1, 2, 0]]),
(
MockClusteringFastTask(seed=1),
{"Level 0": [[0, 0, 0, 0], [0, 0, 1, 0], [0, 1, 2, 1]]},
),
# TODO: #3441
# Disabled due to being too flaky.
# (
# MockClusteringFastTask(seed=1),
# {"Level 0": [[0, 0, 0, 0], [0, 0, 1, 0], [0, 1, 2, 1]]},
# ),
(
MockRegressionTask(),
[pytest.approx([1.0000001192092896, 0.33665788173675537])] * 10,
Expand Down