set OMP_NUM_THREADS during clustering to ensure reproducibility#3400
Merged
KennethEnevoldsen merged 1 commit intov2.0.0from Oct 19, 2025
Merged
set OMP_NUM_THREADS during clustering to ensure reproducibility#3400KennethEnevoldsen merged 1 commit intov2.0.0from
KennethEnevoldsen merged 1 commit intov2.0.0from
Conversation
set OMP_NUM_THREADS during clustering to ensure reproducibility
Samoed
approved these changes
Oct 17, 2025
isaac-chung
reviewed
Oct 18, 2025
| - A dictionary where keys are level names (e.g., "Level 0", "Level 1", etc.) and values are lists of V-measure scores for each clustering experiment at that level. | ||
| - A dictionary where keys are level names and values are lists of cluster assignments for each clustering experiment at that level. | ||
| """ | ||
| # set OMP_NUM_THREADS for reproductibility |
Collaborator
There was a problem hiding this comment.
Can we add a sentence to describe how this ensures reproducibility please?
Contributor
Author
There was a problem hiding this comment.
Yeah, but I am not really sure - it was just the only thing that I expected would vary across CI, @Samoed, and my implementation. However, given that the tests are flaky, it is really hard to tell if it actually ensure anything.
Contributor
Author
There was a problem hiding this comment.
I will merge this for now, just to see if it resolves some of the flakiness - if it does not, I will roll it back.
KennethEnevoldsen
added a commit
that referenced
this pull request
Oct 20, 2025
This rolls back #3400 as it didn't work (as shown in most recent CI on main)
KennethEnevoldsen
added a commit
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set OMP_NUM_THREADS during clustering to ensure reproducibility