[v2] refactor filter_tasks.py out of overview.py and rename overview.py to get_tasks.py #3358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementation is also cleaner and avoid the need for filtering abstasks. To do this I also had to fix a few naming issue where classes names colided.
…py to get_tasks.py Q: `abstask.filter_modalities`, does it actually filter anything (doesn't it just change the metadata which isn't used anywhere?)
Samoed
approved these changes
Oct 14, 2025
Member
Yes, it's weird. Maybe this was done like this to be used in leaderboard, but I'm not sure (source PR #2262) |
Contributor
Author
Hmm, I will try to remove it |
Contributor
Author
|
Couldn't find any place where it was used |
Samoed
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored filter_tasks out of overview.py, this both makes it easier to test segments of get_tasks and it also makes it accecible for use throughout the repo.
I also:
Q:
abstask.filter_modalities, does it actually filter anything (doesn't it just change the metadata which isn't used anywhere?)