Skip to content

fix: Correct logic for filtering public tasks in ModelResult class #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samoed merged 1 commit into from
Oct 1, 2025
Merged

fix: Correct logic for filtering public tasks in ModelResult class #3230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mteb/load_results/benchmark_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def filter_tasks(
if modalities is not None:
if not any(modality in task_meta.modalities for modality in modalities):
continue
if (is_public is not None) and (task_meta.is_public is is_public):
if (is_public is not None) and (task_meta.is_public is not is_public):
continue
new_task_results.append(task_result)
return type(self).model_construct(
Expand Down