-
Notifications
You must be signed in to change notification settings - Fork 655
dataset: Adding JapaneseCode1Retrieval as the first non-public dataset #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KennethEnevoldsen
merged 31 commits into
embeddings-benchmark:main
from
fzoll:adding_the_first_closed_dataset
Sep 16, 2025
Merged
Changes from 4 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
0bffbcc
Adding JapaneseCode1Retrieval as the first non-public dataset
fzoll da4fcad
Transformed dataset
fzoll e196663
Adding as private dataset to tests
fzoll f0807c3
Correct the private task test
fzoll ef047d3
Use the sample dataset as a reference
fzoll 2f48f66
Use the sample dataset as a reference
fzoll 8456668
fix ds loading
Samoed 53476f6
allow on forks
Samoed cb655a5
upd aciton
Samoed 08d7c87
remove paths
Samoed 10eea6a
try to trigger ci
Samoed c6aded6
add ref
Samoed 1242651
add permissions
Samoed db30e8a
remove paths
Samoed d1e4553
add paths back
Samoed 7a9167d
get back to pull request
Samoed 0582b65
rollback action
Samoed b297b78
Trying to resolve the token/secret problem
fzoll 2224ed5
Trying to resolve the token/secret problem
fzoll 3364b46
Update dataset_loading_pr.yml
Samoed 669a24f
Update dataset_loading_pr.yml
Samoed d53e9a0
Try the latest datasets package (worked for me)
fzoll 2e1d0a0
Try the latest datasets package (worked for me)
fzoll ff54120
Try the latest datasets package (worked for me)
fzoll 4ebc3b3
(last?) try
fzoll efbf197
(last?) try
fzoll e556410
(last?) try
fzoll bea2d52
Reverting the changes
fzoll 87a831a
Exclude the private datasets from tests
fzoll ace36e3
Merge branch 'embeddings-benchmark:main' into adding_the_first_closed…
fzoll ac6eab7
Apply suggestions from code review
KennethEnevoldsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from mteb.abstasks.AbsTaskRetrieval import AbsTaskRetrieval | ||
| from mteb.abstasks.TaskMetadata import TaskMetadata | ||
|
|
||
|
|
||
| class JapaneseCode1Retrieval(AbsTaskRetrieval): | ||
| metadata = TaskMetadata( | ||
| name="JapaneseCode1Retrieval", | ||
| description="Japanese code retrieval dataset. Japanese natural language queries paired with Python code snippets for cross-lingual code retrieval evaluation.", | ||
| reference="https://huggingface.co/datasets/mteb-private/JapaneseCode1Retrieval", | ||
| dataset={ | ||
| "path": "mteb-private/JapaneseCode1Retrieval", | ||
| "revision": "fc4cb6390055e65490dfc42526e1d6a379e8cd86", | ||
| }, | ||
| type="Retrieval", | ||
| category="s2p", | ||
| modalities=["text"], | ||
| eval_splits=["test"], | ||
| eval_langs=["jpn-Jpan"], | ||
| main_score="ndcg_at_10", | ||
| date=("2024-01-01", "2024-01-01"), | ||
| domains=["Programming", "Written"], | ||
| task_subtypes=["Code retrieval"], | ||
| license="not specified", | ||
| annotations_creators="derived", | ||
| dialect=[], | ||
| sample_creation="found", | ||
| bibtex_citation="", | ||
| is_public=False, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We state in the blog (will forward it to you @Samoed) that we want to share samples from this. So should this lint be to a
mteb-private/JapaneseCode1Retrieval-sample?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yes. Great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KennethEnevoldsen @Samoed Ok, sure! I will tweak the sample a bit as well. Also, i guess, the sample dataset should be public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KennethEnevoldsen @Samoed https://huggingface.co/datasets/mteb-private/JapaneseCode1Retrieval-sample
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see only qrels split on HF preview. Can you upload it to see qrels and corpus splits too? Also do we want to add samples as tasks too? I think this can help to debug inputs for users if they need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Samoed Please check the dataset now. I don't know if a task is required for the sample, @KennethEnevoldsen ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's better now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage sample is wrong. I would do:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fzoll this is still a issue