-
Notifications
You must be signed in to change notification settings - Fork 655
dataset: Adding JapaneseCode1Retrieval as the first non-public dataset #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
0bffbcc
da4fcad
e196663
f0807c3
ef047d3
2f48f66
8456668
53476f6
cb655a5
08d7c87
10eea6a
c6aded6
1242651
db30e8a
d1e4553
7a9167d
0582b65
b297b78
2224ed5
3364b46
669a24f
d53e9a0
2e1d0a0
ff54120
4ebc3b3
efbf197
e556410
bea2d52
87a831a
ace36e3
ac6eab7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,26 @@ | ||
| name: Datasets available on HuggingFace - PR | ||
|
|
||
| on: | ||
| pull_request: | ||
| pull_request_target: | ||
| types: [opened, synchronize, edited] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still not seeing this workflow being run. I think these 3 lines should be reverted.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I reverted them, but wihtout these lines token from fork will be used, but it not exist there
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I see.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know how to make this action working with pr's from forks. Maybe we can ignore private dataset in action that test them in PR
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, let's ignore for now and start an issue to ask for help.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we just do a simple test to see that the secret is working? (e.g. create a specific CI which loads this private dataset
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried and only passing
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So probably better off skipping private ones in the existing test, and write a separate one for private datasets then eh
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @isaac-chung @Samoed I can exclude the private datasets from this test...but how to test the private datasets?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| paths: | ||
| - "mteb/tasks/**.py" | ||
|
Samoed marked this conversation as resolved.
|
||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
|
|
||
|
|
||
| jobs: | ||
| run-pr-datasets-loading-check: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| # IMPORTANT: For pull_request_target, check out the PR branch explicitly | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
|
|
@@ -23,6 +32,12 @@ jobs: | |
| run: | | ||
| make install-for-tests | ||
|
|
||
| - name: HF auth | ||
| env: | ||
| HF_TOKEN: ${{ secrets.MTEB_PRIVATE }} | ||
|
fzoll marked this conversation as resolved.
Outdated
KennethEnevoldsen marked this conversation as resolved.
Outdated
|
||
| run: | | ||
| hf auth login --token $HF_TOKEN | ||
|
|
||
| - name: Run dataset loading tests | ||
| run: | | ||
| make dataset-load-test-pr BASE_BRANCH=${{ github.event.pull_request.base.ref }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from mteb.abstasks.AbsTaskRetrieval import AbsTaskRetrieval | ||
| from mteb.abstasks.TaskMetadata import TaskMetadata | ||
|
|
||
|
|
||
| class JapaneseCode1Retrieval(AbsTaskRetrieval): | ||
| metadata = TaskMetadata( | ||
| name="JapaneseCode1Retrieval", | ||
| description="Japanese code retrieval dataset. Japanese natural language queries paired with Python code snippets for cross-lingual code retrieval evaluation.", | ||
| reference="https://huggingface.co/datasets/mteb-private/JapaneseCode1Retrieval-sample", | ||
| dataset={ | ||
| "path": "mteb-private/JapaneseCode1Retrieval", | ||
| "revision": "fc4cb6390055e65490dfc42526e1d6a379e8cd86", | ||
| }, | ||
| type="Retrieval", | ||
| category="s2p", | ||
| modalities=["text"], | ||
| eval_splits=["test"], | ||
| eval_langs=["jpn-Jpan"], | ||
| main_score="ndcg_at_10", | ||
| date=("2024-01-01", "2024-01-01"), | ||
| domains=["Programming", "Written"], | ||
| task_subtypes=["Code retrieval"], | ||
| license="not specified", | ||
| annotations_creators="derived", | ||
| dialect=[], | ||
| sample_creation="found", | ||
| bibtex_citation="", | ||
| is_public=False, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some discussion with @fzoll, I think it is better to ignore the private datasets in the test.
There are a couple of reasons: