Skip to content

MAEB Model Evaluation Fixes#2956

Merged
gowitheflow-1998 merged 5 commits intoembeddings-benchmark:maebfrom
AdnanElAssadi56:maeb-models-eval_fixes
Aug 5, 2025
Merged

MAEB Model Evaluation Fixes#2956
gowitheflow-1998 merged 5 commits intoembeddings-benchmark:maebfrom
AdnanElAssadi56:maeb-models-eval_fixes

Conversation

@AdnanElAssadi56
Copy link
Contributor

  • Added 30-second truncation to all models.
  • Added show_progress_bar kwarg for enabling/disabling progress display.

@AdnanElAssadi56
Copy link
Contributor Author

P.S.

  • I've tested some of the models after the changes, but it would probably be a good idea to run all of them. I tried to follow the original implementations as close as possible.
  • If anyone notices missing models, feel free to mention, but I am pretty sure I've done them all.

@KennethEnevoldsen
Copy link
Contributor

@gowitheflow-1998 I think you are the best one to review this PR - do you have the time? We need to invalidate and rerun relevant models after this as well

@gowitheflow-1998 gowitheflow-1998 merged commit 069b294 into embeddings-benchmark:maeb Aug 5, 2025
9 checks passed
isaac-chung added a commit that referenced this pull request Aug 6, 2025
isaac-chung added a commit that referenced this pull request Aug 6, 2025
Revert "MAEB Model Evaluation Fixes (#2956)"

This reverts commit 069b294.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants