Skip to content

Conversation

@YanshekWoo
Copy link
Contributor

Checklist

  • I did not add a dataset, or if I did, I added the dataset checklist to the PR and completed it.
  • I did not add a model, or if I did, I added the model checklist to the PR and completed it.

Model Checklist

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.
  • The model is public, i.e. is available either as an API or the wieght are publicly avaiable to download

xinshuohu added 4 commits June 5, 2025 12:56
Signed-off-by: xinshuohu <xinshuohu@tencent.com>
Signed-off-by: xinshuohu <xinshuohu@tencent.com>
Signed-off-by: xinshuohu <xinshuohu@tencent.com>
@YanshekWoo YanshekWoo changed the title Dev kalm add kalm_models ModelMeta Jun 5, 2025
"MTOPIntentClassification": ["train"],
}

KaLM_Embedding_X_0605 = ModelMeta(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add implementation of your model? If it similar to original KALM, I can push work on that PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it similar to original KALM, I can push work on that PR

Yes, it is almost the same implementation of HIT_TMG__KaLM_embedding_multilingual_mini_instruct_v1.

Perhaps the entire set of models related to KaLM should be moved to kalm_models.py.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will try to finish work on #2478 on weekends then

Copy link
Member

@Samoed Samoed Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanshekWoo can you try to run your models with implementation from #2478? It was merged to main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samoed OK, I will try to test it. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samoed
I have tested the latest version of MTEB (1.38.30), and I believe its results are completely fine now.

Some of the results (from different task type) for HIT-TMG/KaLM-embedding-multilingual-mini-instruct-v1.5 are as follows:

Task Reported Reproduced
EmotionClassification 0.86900 0.86885
FiQA2018 0.44741 0.44072
SprintDuplicateQuestions 0.93057 0.930568
STS12 0.80167 0.801666

The code of evaluation is as follows:

import mteb

# Specify the model that we want to evaluate
model = mteb.get_model("HIT-TMG/KaLM-embedding-multilingual-mini-instruct-v1.5")

# specify what you want to evaluate it on
tasks = mteb.get_tasks(tasks=["EmotionClassification", "FiQA2018", "STS12", "SprintDuplicateQuestions"])

# run the evaluation
evaluation = mteb.MTEB(tasks=tasks)

results = evaluation.run(model,
            encode_kwargs={"batch_size": 256},
            verbosity=2,)

@Samoed Samoed changed the title add kalm_models ModelMeta model: add kalm_models ModelMeta Jun 6, 2025
@KennethEnevoldsen KennethEnevoldsen added the new model Questions related to adding a new model to the benchmark label Jun 24, 2025
@YanshekWoo
Copy link
Contributor Author

I have created a new PR via the latest mteb.
Please refer to the new one: #2850

@YanshekWoo YanshekWoo closed this Jun 25, 2025
@YanshekWoo YanshekWoo deleted the dev_kalm branch June 25, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new model Questions related to adding a new model to the benchmark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants