Skip to content

fix unintentional working of filters on leaderboard #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samoed merged 5 commits into from
Apr 16, 2025
Merged

fix unintentional working of filters on leaderboard #2535

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9156646
fix unintentional working of filters on leaderboard
ayush1298 Apr 11, 2025
2afd58d
address comments
ayush1298 Apr 11, 2025
6bb3f23
make lint
ayush1298 Apr 11, 2025
5bfbbd2
address comments
ayush1298 Apr 16, 2025
8496d17
rollback unnecessary changes
ayush1298 Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions mteb/leaderboard/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,11 +579,17 @@ def update_task_list(
for task in mteb.get_benchmark(benchmark_name).tasks:
if task.metadata.type not in type_select:
continue
if not (set(task.metadata.domains or []) & set(domain_select)):
if task.metadata.domains is not None and not (
set(task.metadata.domains) & set(domain_select)
):
continue
if not (set(task.languages or []) & set(lang_select)):
if task.languages is not None and not (
set(task.languages) & set(lang_select)
):
continue
if not (set(task.metadata.modalities or []) & set(modality_select)):
if task.metadata.modalities and not (
set(task.metadata.modalities) & set(modality_select)
):
continue
tasks_to_keep.append(task.metadata.name)
elapsed = time.time() - start_time
Expand Down
Loading