Skip to content

Add AESDD dataset#2437

Closed
mina-parham wants to merge 9 commits intomaebfrom
AddDataset/AESDD
Closed

Add AESDD dataset#2437
mina-parham wants to merge 9 commits intomaebfrom
AddDataset/AESDD

Conversation

@mina-parham
Copy link
Contributor

@mina-parham mina-parham commented Mar 26, 2025

related to #2359

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

Adding datasets checklist

Reason for dataset addition: ...

  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

@mina-parham mina-parham requested a review from isaac-chung March 26, 2025 05:40
@mina-parham mina-parham self-assigned this Mar 26, 2025
@Samoed Samoed linked an issue Mar 26, 2025 that may be closed by this pull request
@silky1708 silky1708 mentioned this pull request May 7, 2025
84 tasks
@isaac-chung isaac-chung added the audio Audio extension label Jun 1, 2025
Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dataset doesn't seem to exist. Also, could you please run this and report the scores?

mteb run -m facebook/wav2vec2-base -t AESDD
mteb run -m microsoft/wavlm-base -t AESDD

Comment on lines +15 to +16
"path": "mteb/AESDD",
"revision": "afbff14d927de14412d8124502313ea6d9d140e0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to find this dataset. I was only able to find this one.

@KennethEnevoldsen
Copy link
Contributor

@mina-parham it seems like this PR has gotten stale - do you have the time to finalize it?

@mina-parham
Copy link
Contributor Author

@mina-parham it seems like this PR has gotten stale - do you have the time to finalize it?

sure I'll try to finalize this

@isaac-chung
Copy link
Collaborator

@mina-parham this dataset does not seem to work. mteb run -t AESDD -m facebook/wav2vec2-base gives

  File "/opt/homebrew/anaconda3/envs/mteb/lib/python3.11/site-packages/datasets/utils/file_utils.py", line 643, in get_from_cache
    raise FileNotFoundError(f"Couldn't find file at {url}")
FileNotFoundError: Couldn't find file at https://drive.google.com/uc?export=download&id=1-pelMaCrfwoUCmwxUtlacRUBwbFnXlXA&confirm=t

@mina-parham
Copy link
Contributor Author

@mina-parham this dataset does not seem to work. mteb run -t AESDD -m facebook/wav2vec2-base gives

  File "/opt/homebrew/anaconda3/envs/mteb/lib/python3.11/site-packages/datasets/utils/file_utils.py", line 643, in get_from_cache
    raise FileNotFoundError(f"Couldn't find file at {url}")
FileNotFoundError: Couldn't find file at https://drive.google.com/uc?export=download&id=1-pelMaCrfwoUCmwxUtlacRUBwbFnXlXA&confirm=t

The error I’m getting on my side is:

ValueError: The repository for EdwardLin2023/AESDD contains custom code which must be executed to correctly load the dataset. You can inspect the repository content at https://hf.co/datasets/EdwardLin2023/AESDD.
Please pass the argument trust_remote_code=True to allow custom code to be run.

So even after adding trust_remote_code=True, I’m still getting the same error.
Do you know how to fix this?

@isaac-chung
Copy link
Collaborator

The error I’m getting on my side is:
ValueError: The repository for EdwardLin2023/AESDD contains custom code which must be executed to correctly load the dataset. You can inspect the repository content at https://hf.co/datasets/EdwardLin2023/AESDD.
Please pass the argument trust_remote_code=True to allow custom code to be run.
So even after adding trust_remote_code=True, I’m still getting the same error.
Do you know how to fix this?

Have you tried make install to install the repo in edit mode? I still get this error with your latest changes.

@Samoed Samoed deleted the AddDataset/AESDD branch October 19, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audio Audio extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add AESDD

4 participants