fix FSD-50K Task Metadata, Label handling and add stratified subsampling#2369
Merged
isaac-chung merged 1 commit intoembeddings-benchmark:maebfrom Mar 18, 2025
Merged
Conversation
8 tasks
Author
|
|
Samoed
reviewed
Mar 15, 2025
| self.label_column_name: x[self.label_column_name].split(","), | ||
| } | ||
| ) | ||
| self.dataset = self.stratified_subsampling( |
Member
There was a problem hiding this comment.
I don't think you should add stratified subsampling
Author
There was a problem hiding this comment.
there are 5k test samples which is > 2048 as mentioned in the pr descp so i added it, I can remove subsampling
Collaborator
There was a problem hiding this comment.
Thanks for following the PR template. It's fine to stay.
isaac-chung
approved these changes
Mar 18, 2025
| self.label_column_name: x[self.label_column_name].split(","), | ||
| } | ||
| ) | ||
| self.dataset = self.stratified_subsampling( |
Collaborator
There was a problem hiding this comment.
Thanks for following the PR template. It's fine to stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes concerns of #2285 (comment) and adds stratified subsampling for test set
Code Quality
make lintto maintain consistent style.Documentation
Testing
make test-with-coverage.make testormake test-with-coverageto ensure no existing functionality is broken.