Skip to content

Add audioset (WIP)#2331

Merged
isaac-chung merged 2 commits intoembeddings-benchmark:add-audioset-2from
anime-sh:audioSet
Jul 27, 2025
Merged

Add audioset (WIP)#2331
isaac-chung merged 2 commits intoembeddings-benchmark:add-audioset-2from
anime-sh:audioSet

Conversation

@RahulSChand
Copy link

@RahulSChand RahulSChand commented Mar 11, 2025

Add audioset dataset part of #2319 . Also addressed #2049

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

Adding datasets checklist

Reason for dataset addition: ...

  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Adding a model checklist

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.

@RahulSChand RahulSChand added the maeb Audio extension label Mar 11, 2025
@RahulSChand RahulSChand self-assigned this Mar 11, 2025
@RahulSChand RahulSChand marked this pull request as draft March 11, 2025 19:13
@RahulSChand RahulSChand mentioned this pull request Mar 11, 2025
@RahulSChand RahulSChand changed the title Add audioset draft commit (WIP) Add audioset (WIP) Mar 11, 2025
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The description of task is missing.

Please remove irrelevant stuff (model checklist) from the message. I would also really like to see that a model has actually been run on the task to confirm that it works.

@RahulSChand
Copy link
Author

Thanks for the PR. The description of task is missing.

Please remove irrelevant stuff (model checklist) from the message. I would also really like to see that a model has actually been run on the task to confirm that it works.

Yeah, makes sense. Its currently a draft PR haven't run the actual model yet to get the numbers. Again this dataset is bigger than others so it will take some time

@silky1708 silky1708 mentioned this pull request May 7, 2025
84 tasks
@KennethEnevoldsen
Copy link
Contributor

@RahulSChand I will close this - as it seems to have gotten stale

@isaac-chung isaac-chung reopened this Jun 21, 2025
@isaac-chung isaac-chung reopened this Jul 27, 2025
@isaac-chung isaac-chung changed the base branch from maeb to add-audioset-2 July 27, 2025 18:35
@isaac-chung isaac-chung marked this pull request as ready for review July 27, 2025 18:39
@isaac-chung isaac-chung merged commit d7f3bd3 into embeddings-benchmark:add-audioset-2 Jul 27, 2025
3 of 8 checks passed
isaac-chung added a commit that referenced this pull request Jul 28, 2025
* update citation script

* Add audioset (WIP) (#2331)

Added audioset draft commit

Co-authored-by: Isaac Chung <chungisaac1217@gmail.com>

* update audioset metadata

* add audioset mini

* use lrap

---------

Co-authored-by: Rahul C <chandrahul0320@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maeb Audio extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants