Skip to content

fix: bug in voyage implementation #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KennethEnevoldsen merged 2 commits into from
Mar 10, 2025
Merged

fix: bug in voyage implementation #2304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f2dc47
fix: Fix bug in voyage implementation
KennethEnevoldsen Mar 10, 2025
d34cda9
Update mteb/models/voyage_models.py
KennethEnevoldsen Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mteb/models/voyage_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ def encode(
**kwargs: Any,
) -> np.ndarray:
prompt_name = self.get_prompt_name(self.model_prompts, task_name, prompt_type)
input_type = prompt_name if prompt_name is not None else "document"
prompt_name = self.get_prompt_name(self.model_prompts, task_name, prompt_type)
prompt_name = (
"document" if (prompt_name == "passage") else prompt_name
) # remap to voyage format
input_type = prompt_name if (prompt_name is not None) else "document"
Comment thread
KennethEnevoldsen marked this conversation as resolved.
Outdated

return self._batched_encode(sentences, batch_size, input_type)

def _batched_encode(
Expand Down