Added Wav2Vec model, voice clustering task, VoxCeleb dataset subset#2175
Added Wav2Vec model, voice clustering task, VoxCeleb dataset subset#2175isaac-chung merged 25 commits intoembeddings-benchmark:maebfrom
Conversation
isaac-chung
left a comment
There was a problem hiding this comment.
Thanks for separating this out! I think we're close. A few comments here. Also, please make sure the tests pass.
Based on this comment, it seemed like the newly added task and model can be run. Please also share the command / script used in the PR description, like so:
import mteb
#example code here|
Does anyone know why we are failing the lint test? When I run |
|
@alisartazkhan try |
|
@isaac-chung I tried both |
|
@alisartazkhan what ruff version are you using? This branch seems to be using |
|
I see. I'm using |
|
@alisartazkhan the |
isaac-chung
left a comment
There was a problem hiding this comment.
Nice work team! Just one final small thing. The alternative is just to specify the "train" split.
|
I just made the final adjustment. Let me know if there's anything else. Thanks for the continuous support @isaac-chung and @Samoed ! |
|
Looks good, thanks for iterating! I'll enable auto-merge now. |
Code Quality
make lintto maintain consistent style.Documentation
Testing
make test-with-coverage.make testormake test-with-coverageto ensure no existing functionality is broken.Adding a model checklist
mteb.get_model(model_name, revision)andmteb.get_model_meta(model_name, revision)Command