Skip to content

Revert "feat: Merge MIEB into main 🎉 "#1957

Merged
gowitheflow-1998 merged 7 commits intomainfrom
revert-1944-mieb
Feb 5, 2025
Merged

Revert "feat: Merge MIEB into main 🎉 "#1957
gowitheflow-1998 merged 7 commits intomainfrom
revert-1944-mieb

Conversation

@isaac-chung
Copy link
Collaborator

@isaac-chung isaac-chung commented Feb 4, 2025

Reverts #1944 to recreate the co-author list manually. Once this is merge, I'll create a PR from mieb again, resolve merge conflicts, then manually add co-authors based on this commit message.

Here is an example of what we want to achieve.

@Samoed
Copy link
Member

Samoed commented Feb 4, 2025

I don't think reapplying for PR would be helpful. Instead, I think PR should be open at all times, allowing all contributors to be listed.

@isaac-chung
Copy link
Collaborator Author

We want the merge PR commit to credit all contributors like so:
image-2.png

Can you be more specific on how your suggestion would achieve that?

@isaac-chung
Copy link
Collaborator Author

Linting is failing. Created #1961

@Samoed
Copy link
Member

Samoed commented Feb 5, 2025

I'm not sure how to acive that, because in the PR commit history, contributors were listed, but they are not listed in the resulting commit. And reukt commit seems wierd, because there is less contributors

@isaac-chung
Copy link
Collaborator Author

We will revert and re-add a PR with the mieb branch. I anticipate some merge conflicts, and will add a dummy change if needed. Also updated the PR description here with the plan. My bad for merging pre-maturely!

@gowitheflow-1998 gowitheflow-1998 merged commit 2c62d21 into main Feb 5, 2025
11 checks passed
@gowitheflow-1998 gowitheflow-1998 deleted the revert-1944-mieb branch February 5, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments