Conversation
|
I have also made some changes on this over on main. I would probably do a merge before (my fix removed |
Co-authored-by: Kenneth Enevoldsen <kennethcenevoldsen@gmail.com>
|
No, Line 65 in dba7a95 |
|
(we could also consider merging this and resolving it in a merge/partial merge) |
Yes, but it is not in So yea, no merge is needed |
KennethEnevoldsen
left a comment
There was a problem hiding this comment.
Alright, looking a bit more into this. Are there cases where we can't replace .is_multilingual?
|
No, we can totally remove |
b74cbf3 to
d0cdc39
Compare
isaac-chung
left a comment
There was a problem hiding this comment.
Maybe I'm missing something: how do we determine which subsets to load? Does is_multilingual play a role or do we just check for the presence of a default subset?
Co-authored-by: Isaac Chung <chungisaac1217@gmail.com>
By Line 315 in dba7a95
Previously yes, but now we can get subsets with |
|
Sorry, I didn't phrase the question right. What I'm curious about is the evidence supporting this statement:
|
ef07074 to
d0eb782
Compare
Yes, for now, hf_subsets = list(self.dataset) if self.is_multilingual else ["default"] |
|
I think we can make is_multilingual just property of TaskMetadata that would be calculated based on |
isaac-chung
left a comment
There was a problem hiding this comment.
Looks good! Just got one small suggestion.
Co-authored-by: Isaac Chung <chungisaac1217@gmail.com>
Closes #1832
I've removed
MultilingualTaskand explicitly addedis_multilingualto tasks, which was previously handled byMultilingualTask. I also moved thefast_loadingmethod fromMultilingualTasktoAbsTask, but I think we should reupload these datasets in the correct format.Additionally, we might want to determine
is_multilingualautomatically based oneval_langs, but I’m not entirely in favor of this since it feels a bit like magic. Another option is to integrateis_multilingualintoTaskMetadata.Code Quality
make lintto maintain consistent style.Documentation
Testing
make test-with-coverage.make testormake test-with-coverageto ensure no existing functionality is broken.