Skip to content

fix: Hotfixed public_training_data type annotation #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x-tabdeveloping merged 1 commit into from
Jan 22, 2025
Merged

fix: Hotfixed public_training_data type annotation #1857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mteb/model_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class ModelMeta(BaseModel):
license: str | None
open_weights: bool | None
public_training_code: str | None
public_training_data: str | None
public_training_data: str | bool | None
Comment on lines 97 to +98

@isaac-chung isaac-chung Jan 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at #1794 where this was first removed, do we want to revert these back to bool for both "public" fields, instead of str?

@x-tabdeveloping x-tabdeveloping Jan 22, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since public_training_code hasn't caused any problems anywhere to my knowledge, I would keep it as is

framework: list[FRAMEWORKS]
reference: STR_URL | None = None
similarity_fn_name: DISTANCE_METRICS | None
Expand Down