Skip to content

fix: Fixed leaderboard search bar #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x-tabdeveloping merged 1 commit into from
Jan 22, 2025
Merged

fix: Fixed leaderboard search bar #1852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mteb/leaderboard/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def filter_models(
with gr.Row():
searchbar = gr.Textbox(
label="Search Models",
info="Search models by name (RegEx sensitive. Separate queries with `|`)",
info="Press Enter to search.\nSearch models by name (RegEx sensitive. Separate queries with `|`)",
interactive=True,
)
compatibility = gr.CheckboxGroup(
Expand Down Expand Up @@ -626,7 +626,7 @@ def update_tables(
inputs=[scores, searchbar, task_select, models],
outputs=[summary_table, per_task_table],
)
searchbar.input(
searchbar.submit(
update_tables,
inputs=[scores, searchbar, task_select, models],
outputs=[summary_table, per_task_table],
Expand Down
5 changes: 5 additions & 0 deletions mteb/leaderboard/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@ def scores_to_tables(
names = per_task.index.get_level_values("model_name")
names = pd.Series(names, index=per_task.index)
to_remove |= ~names.str.contains(search_query, regex=True)
if to_remove.all():
no_results_frame = pd.DataFrame(
{"No results": ["You can try relaxing your criteria"]}
)
return gr.DataFrame(no_results_frame), gr.DataFrame(no_results_frame)
models_to_remove = list(per_task[to_remove].index)
typed_mean = mean_per_type.mean(skipna=False, axis=1)
overall_mean = per_task.mean(skipna=False, axis=1)
Expand Down
Loading