Skip to content

fix: nomic tensor return #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samoed merged 2 commits into from
Jan 2, 2025
Merged

fix: nomic tensor return #1683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4d0f50
fix nomic tensor return
Samoed Jan 2, 2025
bebaee2
add typehint
Samoed Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions mteb/models/nomic_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from functools import partial
from typing import Any

import numpy as np
import torch
import torch.nn.functional as F
from sentence_transformers import SentenceTransformer
Expand Down Expand Up @@ -43,7 +44,7 @@ def encode( # type: ignore
prompt_type: PromptType | None = None,
batch_size: int = 32,
**kwargs: Any,
):
) -> np.ndarray:
input_type = self.get_prompt_name(self.model_prompts, task_name, prompt_type)

# default to search_document if input_type and prompt_name are not provided
Expand All @@ -60,8 +61,9 @@ def encode( # type: ignore
emb = torch.tensor(emb)
emb = F.layer_norm(emb, normalized_shape=(emb.shape[1],))
emb = F.normalize(emb, p=2, dim=1)
if kwargs.get("convert_to_tensor", False):
emb = emb.cpu().detach().numpy()

if isinstance(emb, torch.Tensor):
emb = emb.cpu().detach().float().numpy()

return emb

Expand Down
Loading