Skip to content

Update results_to_dataframe to use BenchmarkResults class #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaac-chung merged 1 commit into from
Dec 24, 2024
Merged

Update results_to_dataframe to use BenchmarkResults class #1628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions mteb/task_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from sklearn.preprocessing import StandardScaler
from tqdm import tqdm

import mteb
from mteb.load_results.benchmark_results import BenchmarkResults

MODEL_NAME = str
REVISION = str
Expand All @@ -35,7 +35,7 @@ def mse_with_zscore(x: list[float], y: list[float]) -> float:


def results_to_dataframe(
mteb_results: dict[MODEL_NAME, dict[REVISION, list[mteb.MTEBResults]]],
mteb_results: BenchmarkResults,
drop_na: bool = True,
**kwargs: Any,
) -> pd.DataFrame:
Expand All @@ -47,17 +47,16 @@ def results_to_dataframe(
**kwargs: Additional keyword arguments to be passed to the `get_score` method of the `MTEBResults` class.
"""
data = []
for model_name, revisions in mteb_results.items():
for rev, tasks_results in revisions.items():
for task_result in tasks_results:
data.append(
{
"Model": model_name,
"Revision": rev,
"task": task_result.task_name,
"main_score": task_result.get_score(**kwargs),
}
)
for model_res in mteb_results:
for task_result in model_res.task_results:
data.append(
{
"Model": model_res.model_name,
"Revision": model_res.model_revision,
"task": task_result.task_name,
"main_score": task_result.get_score(**kwargs),
}
)
df = pd.DataFrame(data)

if drop_na:
Expand Down
Loading