Skip to content

fix: loading pre 1.11.0 #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x-tabdeveloping merged 2 commits into from
Nov 15, 2024
Merged

fix: loading pre 1.11.0 #1460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3804f1
small fix
Samoed Nov 15, 2024
19db4b2
fix: fix
Samoed Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions mteb/load_results/task_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,14 @@ def from_disk(cls, path: Path, load_historic_data: bool = True) -> TaskResult:
)

pre_1_11_load = (
"mteb_version" in data
and data["mteb_version"] is not None
and Version(data["mteb_version"]) < Version("1.11.0")
(
"mteb_version" in data
and data["mteb_version"] is not None
and Version(data["mteb_version"]) < Version("1.11.0")
)
or "mteb_version" not in data
) # assume it is before 1.11.0 if the version is not present

try:
obj = cls.model_validate(data)
except Exception as e:
Expand Down