Conversation
0deffed to
ca31489
Compare
huntc
left a comment
There was a problem hiding this comment.
I infer that the goal here is to permit new people to get started with Embassy a means to do so without having to pin their toolchains. if that's the case, then perhaps we should make all of the examples avoid nightly features... The examples should always be easy to apply to one's own code. Thoughts
|
The experience is really bad if you can't use Not being able to use async traits is really bad, this means you won't be able to use any async hal-independent driver. I see stable support as the following:
|
huntc
left a comment
There was a problem hiding this comment.
Approving given that I now fully understand the motivation.
|
bors r+ |
|
Actually, for blocking HAL use, stable support is quite valuable. |
|
Build succeeded: |
This PR adds (limited) stable Rust support!
The drawbacks are:
#[embassy::task],#[embassy::main]. (requirestype_alias_impl_trait). You have to manually allocate the tasks somewhere they'll live forever. See exampleconst_fn_trait_bound), although there's an (ugly) workaround for the genericMutex.So it's not that bad in the end, it's fully usable for shipping production-ready firmwares. We'll still recommend nightly as the default, until GATs and
type_alias_impl_traitare stable.