Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #3151

Closed
Closed

test #3151

Conversation

piotrkrygier-intent
Copy link

@piotrkrygier-intent piotrkrygier-intent commented Jul 4, 2024

No description provided.

Work in progres, there is a problem with exponent.
@piotrkrygier-intent piotrkrygier-intent marked this pull request as draft July 4, 2024 06:51
@Dirbaio Dirbaio added the trusted label Jul 4, 2024
@Dirbaio
Copy link
Member

Dirbaio commented Jul 4, 2024

Very nice!

Could you add hardware-in-the-loop (HIL) tests, similar to all the other crypto drivers? The steps should be something like:

  • Add a pka feature, enable it for all chips that have PKA in Cargo.toml
  • Add tests here, mark with // required-features: pka
  • run gen_test.py

with the trusted label HIL tests will run every time you push to this PR. I can also give you a token so you can run the tests on the test farm with cargo run from your local machine for faster iteration, if interested please DM me on Matrix.

@piotrkrygier-intent piotrkrygier-intent changed the title [TR3FIR-217] Implemented PKA driver. test Jul 10, 2024
@piotrkrygier-intent piotrkrygier-intent deleted the pka_implement branch July 10, 2024 06:35
@piotrkrygier-intent
Copy link
Author

No. I'll need to rewrite this. Please delete this PR and wait for the updated version, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants