Skip to content

Conversation

@jcs090218
Copy link
Member

Cask is deprecated, use Eask instead. 🤔

@jcs090218
Copy link
Member Author

You can see the test result in jcs-PR#1.

@psibi
Copy link
Member

psibi commented Sep 16, 2024

Thanks! I didn't realize that cask was deprecated. Was it announced somewhere ?

@jcs090218
Copy link
Member Author

They do not add new features or rarely do bug fixes. Some Emacs users declared it semi-deprecated, and I think that's true. AFAIK Cask no longer supports Windows, it’s deprecated for people who use Windows (like me). 🤔

Some people still use Cask since it will continue to support Linux (I don't know about macOS).

@psibi
Copy link
Member

psibi commented Sep 17, 2024

Thanks, got it. I don't have any objections to it, but I want to verify if I can use eask locally. The last time I checked it didn't work in NixOS.

experimental: [false]
include:
- os: ubuntu-latest
emacs-version: snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this can be removed ? It is intentional that I don't want to test on snapshot. I have seen occasional failures occurring just on snapshot which marks the entire CI as red IIRC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Removed!

# emacs-version: snapshot
# experimental: true
exclude:
- os: macos-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed since we don't test on macos anyway ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to add the macos test in the future. But I guess we can remove it for now. :)

@jcs090218
Copy link
Member Author

Thanks, got it. I don't have any objections to it, but I want to verify if I can use eask locally. The last time I checked it didn't work in NixOS.

No problem! I think I accidentally removed the lock file that nixpkgs used to build the package. It should be working now; see https://search.nixos.org/packages?channel=unstable&show=eask-cli&from=0&size=50&sort=relevance&type=packages&query=eask.

@psibi psibi merged commit 3e3257e into emacs-rustic:main Sep 28, 2024
@psibi
Copy link
Member

psibi commented Sep 28, 2024

Thank you!

@jcs090218
Copy link
Member Author

Continue the conversation at rust-lang/rust-mode#557.

Feel free to add me as the maintainer to this project! :)

@psibi
Copy link
Member

psibi commented Oct 1, 2024

Feel free to add me as the maintainer to this project! :)

Thanks, just sent an invite.

@jcs090218 jcs090218 deleted the ci/eask branch October 1, 2024 05:02
@jcs090218
Copy link
Member Author

Thanks, just sent an invite.

Joined! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants