WIP: toggle completion caching whether number of candidates reaches limit #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kermorgant
changed the title
if the number of suggested candidates reaches the limit, the desired candidate might be missing. If that occurs, caching should not be used when typing more characters of the completed string, as phpactor will be invoked with a longer prefix, and have more chances to return the desired candidate.
kermorgant
force-pushed
the
completion-caching-toggle
branch
from
df34adf
to
9e12ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the number of suggested candidates reaches the limit, the desired
candidate might be missing.
If that occurs, caching should not be used when typing more characters
of the completed string, as phpactor will be invoked with a longer
prefix, and have more chances to return the desired candidate.
fixes #50
EDIT : this still needs to be tested. I'll try to use test this in a near future by lowering phpactor's
completion.completor.class.limitvalue in order to trigger that code more often