Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpactor projectile root detection #144

Closed
wants to merge 1 commit into from

Conversation

Sasanidas
Copy link

With this little change we can make phpactor be automatically aware of projectile root

With this little change we can make phpactor be automatically aware of projectile root
phpactor.el Show resolved Hide resolved
@zonuexe
Copy link
Member

zonuexe commented Jan 21, 2020

@Sasanidas
What root can't be detected without projectile? Please explain why you need this patch.

@zonuexe
Copy link
Member

zonuexe commented Jan 21, 2020

@Sasanidas
The replacement by Projectile was applied to php-project instead of phpactor.el.
Enabling php-project-use-projectile-to-detect-root applies, to use projectile for Phpactor.
If you update php-mode and it doesn't work as expected, please let me know.

Thank you.

@Sasanidas Sasanidas closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants