Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Emacs >= 29.1, php-function-call face inherits from font-lock-function-call-face #783

Conversation

bricka
Copy link
Contributor

@bricka bricka commented Jun 20, 2024

Resolves #782

@zonuexe
Copy link
Member

zonuexe commented Jun 20, 2024

@bricka
Your change is very reasonable, and I thought last night that this change was enough. However, I am concerned that it will cause cognitive friction, because the difference from the existing display is large depending on the theme used by the user. Therefore, I proposed a new face and an opt-in variable to switch to the "-standard" face in #784.

I'm sorry, but I would like to merge #784 instead of this PR, and rest assured that your contribution is recorded in that branch as well. Your contribution is very much appreciated!

@zonuexe zonuexe closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php-function-call face does not inherit from font-lock-function-call-face
2 participants