Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the heredoc regexp. #651

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

antoineB
Copy link
Contributor

@antoineB antoineB commented Feb 2, 2021

To support heredoc in this style:
<<< 'HEREDOC'
instead of
<<<'HEREDOC'

@cjohansson
Copy link
Member

If you want to use the same RegEx as PHP does you can see it here: https://github.com/cjohansson/emacs-phps-mode/blob/master/phps-mode-lexer.el#L1546

There can be tabs prefixed as well, the label is not any characters and there needs to be a newline following the label

To support heredoc in this style:
<<< 'HEREDOC'
instead of
<<<'HEREDOC'
@antoineB antoineB force-pushed the feature/heredoc-regexp branch from 4955f92 to fbead70 Compare March 1, 2021 14:19
@zonuexe zonuexe merged commit 53da0b4 into emacs-php:master Mar 6, 2021
@zonuexe
Copy link
Member

zonuexe commented Mar 6, 2021

@antoineB Thanks!

@zonuexe zonuexe mentioned this pull request Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants