Add a "Hall of Fame" to the contributors list #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes use of https://github.com/sourcerer-io/hall-of-fame to display a Hall of Fame for the top contributors. There are two purposes to this addition: 1. To show gratitude. 2. To hopefully encourage more contributions. Admittedly there is some concern this may invite developers to "game" the system, i.e. trying "win" the Hall of Fame by submitting more patches. In other words, it could invite a problem of quantity over quality. However, I have fath that the emacs-php community is more mature than that. This patch does not update the Japanese version of the README since it explicitly links to the list of contributors in the English version. Special-thanks: @emacs-php Special-thanks: Every contributor ever Signed-off-by: Eric James Michael Ritz <[email protected]>
|
Note that it may take at least an hour for the content to appear in the README, due to the large number of contributions to process. |
|
This is not having the intended effect so clearly I misunderstood something about the process. |
|
Well, I see that the code you obtained is not working. https://github.com/emacs-php/php-mode/blob/hall-of-fame/README.md I also got it, but it is the same. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes use of
to display a Hall of Fame for the top contributors. There are two
purposes to this addition:
Admittedly there is some concern this may invite developers to
"game" the system, i.e. trying "win" the Hall of Fame by submitting
more patches. In other words, it could invite a problem of quantity
over quality. However, I have fath that the emacs-php community is
more mature than that.
This patch does not update the Japanese version of the README since
it explicitly links to the list of contributors in the English version.
Special-thanks: @emacs-php
Special-thanks: Every contributor ever
Signed-off-by: Eric James Michael Ritz [email protected]