Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlighting of callable keyword #471

Merged

Conversation

fabacino
Copy link
Contributor

@fabacino fabacino commented Jun 8, 2018

If the keyword callable is used as a type hint or a return type, it is highlighted as a keyword instead of a type.

Example:

public function decorate(callable $function): callable
//                       ^^^^^^^^             ^^^^^^^^

This commit fixes this inconsistency and highlights it as a type in these situations.

If the keyword `callable` is used as a type hint or a return type, it
is highlighted as a keyword instead of a type.

This commit fixes this inconsistency.
@zonuexe
Copy link
Member

zonuexe commented Jun 8, 2018

Before

2018-06-08 6 48 59

After

2018-06-08 6 49 14

@zonuexe zonuexe merged commit cf1907b into emacs-php:master Jun 8, 2018
@zonuexe
Copy link
Member

zonuexe commented Jun 8, 2018

@fabacino Thanks a lot!

@fabacino fabacino deleted the bugfix/fix-callable-highlighting branch June 8, 2018 10:42
@zonuexe zonuexe mentioned this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants