Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 7.1 return types support #469

Closed
Moghul opened this issue May 18, 2018 · 2 comments
Closed

Php 7.1 return types support #469

Moghul opened this issue May 18, 2018 · 2 comments

Comments

@Moghul
Copy link

Moghul commented May 18, 2018

Consider a function like

    public function getProperty() : ?PropertyType {
        return $this->property;
    }

where our $property is a nullable PropertyType variable.

Currently, php-mode 1.19.1 will show an exception for that question mark. Is it possible to change a setting to make that work right or does it need to be implemented within php-mode?

@zonuexe
Copy link
Member

zonuexe commented May 21, 2018

@Moghul
Thank you for suggestion. As you say, the symbol ? does not have its own face.

It is not difficult to write a pattern that colors ? in your quoted code, but I think that there is a slightly annoying problem when considering the consistency of the argument list and so on.
It depends not only on the pattern of php - mode but also on the implementation of Cc Mode.

We welcome if you have an idea to solve this problem.

@Moghul
Copy link
Author

Moghul commented May 21, 2018

I know less than nothing about how emacs & its plugins work, and never learned lisp. I'm not the guy to solve your issue, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants