lsp-clients: fix disabling snippet completion for go #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the disableFuncSnippet initialization option which is recognized by the bingo language server.
|
BTW, I don't really understand why there are two ways to disable snippet completion for |
This is go language server specific setting while lsp-enable-snippet is the standard setting in lsp protocol - refer to the spec https://microsoft.github.io/language-server-protocol/specification |
|
Thank you for the PR and congrats for your first |
|
I'll try to also fix the bingo server so it doesn't send snippets if they're not announced in client capabilities. |
waymondo
pushed a commit
to waymondo/lsp-mode
that referenced
this pull request
Feb 26, 2019
This adds the disableFuncSnippet initialization option which is recognized by the bingo language server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the disableFuncSnippet initialization option which is recognized by the bingo
language server. See https://github.com/saibing/bingo/blob/master/langserver/initialization.go for supported initialization options.